liuxiran commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r599481208
##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -667,6 +667,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
name: formatMessage({ id:
'page.upstream.step.select.upstream.select.option' }),
id: '',
},
+ {
Review comment:
Hi @stu01509
I noticed that we already have `None` option, see
https://github.com/apache/apisix-dashboard/pull/1633/files#diff-0029901a283985aea1e8e47cfb2d45c9c8eef8cb392e12ed31720390a22ec269R664
and this will be controlled by `required` param, you can try to pass
`required={false}` in
https://github.com/apache/apisix-dashboard/blob/9c27b57dc5d2549706a8348f1a036743246f0337/web/src/pages/Service/components/Step1.tsx#L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
