starsz commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r605372197
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -233,6 +233,9 @@ http {
{% end %}
{% end %}
+ # error_page
+ error_page 500 502 503 504 @apisix_error_handler;
Review comment:
Now the 4xx situation like:
404: {"error_msg":"404 Route Not Found"}
401: {"code":4107,"message":"request
unauthorized","data":null,"request_id":""}
We will return JSON, do this need to add an error page?
IMO, it doesn't need now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
