juzhiyuan commented on a change in pull request #1689: URL: https://github.com/apache/apisix-dashboard/pull/1689#discussion_r606734858
########## File path: docs/en/latest/USER_GUIDE.md ########## @@ -23,31 +23,31 @@ title: User Guide The following are parts of the modules' snapshot. -## Metrics +## Dashboard We support the monitor page by referencing it in [iframe](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe). Before accessing [Grafana](https://grafana.com/), please Enable [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding), which defaults to `false`. This causes the browser to fail to render Grafana pages properly due to security policies. - + Review comment: 🤔 that's a problem. - If we put them in our repo, it's easy to maintain actually, but will make the `pull` action slower; - if we put them in the CDN, we need to upload them when updating the images, but will speedup the pull action. Both are ok to me, how about others' opinion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
