starsz commented on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823705817


   > > how about ./manager-api start and ./manager-api stop,
   > > when run ./manager-api start and the service is not installed, install 
it ?
   > 
   > Okay then, I will take care of checking and installing(if required) for 
`./manager-api start`.
   > And yes, actual commands instead of flags would look nice, thanks for 
that. Regarding the commands I think, we could provide install, remove and 
status too.
   > 
   > * ./manager-api start
   > * ./manager-api stop
   > * ./manager-api status  (option to check service status from the binary 
itself without depending on os specific service manager)
   > * ./manager-api remove (would be helpful deleting service test file 
without manually navigating to the filesystem)
   > * ./manager-api install  (reinstalling the service, if the binary location 
needs to be changed in future, service must be reinstalled. Also in newer 
releases if we introduce extra flags, that should be passed as arguments for 
ExecStart of the service unit file i.e. need reinstallation)
   > 
   > what do you think :)
   
   LGTM too!.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to