1502shivam-singh commented on pull request #1805:
URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-824137732


   > 
![image](https://user-images.githubusercontent.com/2106987/115421233-5c8ef480-a22e-11eb-99ff-958ffe39915e.png)
   
   Nice 👍
   Didn't knew some plugin-icons were already designed.
   
   Something to mention (I should have mentioned this earlier now I feel) we 
should keep icons with same prefix or suffix together and have these ones with 
similar style like for `"serverless-post and pre functions"`. To explicitly 
mention here, by similar style I don't only mean color from the APISIX pallete 
or other, I mean similar color schemes and color softness, with focus on the 
idea that should resonate from that icon.
   
   For example we have situation here that, all auth ones but jwt-auth have 
similar style.
   - Easiest way to circumvent this for now is to redesign "jwt-auth" and make 
some small guide or better follow some already created one, to design rest of 
the icons (like the duotone style followed currently).
   
   Also, something with sizes of the icons. Some look smaller than other like 
the `cors` and `wolf-rbac` one for instance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to