[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1816: feat: Use monaco editor

[GitBox]

guoqqqi commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r620414773



##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -14,34 +14,34 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import React, { useEffect, useRef, useState } from 'react';
+import React, { useEffect, useState } from 'react';
 import {
+  Alert,
   Button,
+  Divider,
+  Drawer,
+  Form,
+  Input,
   notification,
   PageHeader,
-  Switch,
-  Form,
+  Popconfirm,
   Select,
-  Divider,
-  Drawer,
-  Alert,
   Space,
-  Popconfirm,
-  Tooltip,
-  Input,
+  Switch,
 } from 'antd';
 import { useIntl } from 'umi';
-import CodeMirror from '@uiw/react-codemirror';
 import { js_beautify } from 'js-beautify';
 import { LinkOutlined } from '@ant-design/icons';
 import Ajv from 'ajv';
 import type { DefinedError } from 'ajv';
 import addFormats from 'ajv-formats';
 
 import { fetchSchema } from './service';
-import { json2yaml, yaml2json } from '../../helpers';
+import { json2yaml, yaml2json } from '@/helpers';
 import { PluginForm, PLUGIN_UI_LIST } from './UI';
 import { PluginType } from './data';
+import MonacoEditor from "react-monaco-editor";
+import type * as monacoEditor from "monaco-editor";

Review comment:
       These two lines seem to go on line 38

##########
File path: web/src/pages/Route/components/DebugViews/DebugDrawView.tsx
##########
@@ -27,18 +26,20 @@ import { CopyOutlined } from "@ant-design/icons";
 import PanelSection from '@/components/PanelSection';
 
 import {
-  HTTP_METHOD_OPTION_LIST,
-  DEFAULT_DEBUG_PARAM_FORM_DATA,
-  DEFAULT_DEBUG_AUTH_FORM_DATA,
-  PROTOCOL_SUPPORTED,
+  DEBUG_BODY_MODE_SUPPORTED,
   DEBUG_BODY_TYPE_SUPPORTED,
-  DEBUG_BODY_CODEMIRROR_MODE_SUPPORTED,
-  DEBUG_RESPONSE_BODY_CODEMIRROR_MODE_SUPPORTED,
+  DEBUG_RESPONSE_BODY_MODE_SUPPORTED,
   DebugBodyFormDataValueType,
+  DEFAULT_DEBUG_AUTH_FORM_DATA,
+  DEFAULT_DEBUG_PARAM_FORM_DATA,
+  HTTP_METHOD_OPTION_LIST,
+  PROTOCOL_SUPPORTED,
 } from '../../constants';
-import { DebugParamsView, AuthenticationView, DebugFormDataView } from '.';
+import { AuthenticationView, DebugFormDataView, DebugParamsView } from '.';
 import { debugRoute } from '../../service';
 import styles from './index.less';
+import MonacoEditor from "react-monaco-editor";
+import type * as monacoEditor from "monaco-editor";

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org