[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1828: fix:When create the upstream, some properties can still be edited on …

[GitBox]

guoqqqi commented on a change in pull request #1828:
URL: https://github.com/apache/apisix-dashboard/pull/1828#discussion_r620448463



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -83,6 +83,7 @@ const UpstreamForm: React.FC<Props> = forwardRef(
 
     const resetForm = (upstream_id: string) => {
       if (upstream_id === undefined) {
+        setReadonly(disabled);

Review comment:
       Yes, currently all can be edited on the preview page when first 
configuring upstream.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org