bisakhmondal commented on a change in pull request #1788:
URL: https://github.com/apache/apisix-dashboard/pull/1788#discussion_r622098388
##########
File path: Makefile
##########
@@ -50,10 +59,17 @@ endif
.PHONY: api-default
api-default:
ifeq ("$(wildcard $(GO_EXEC))", "")
- @echo "ERROR: Need to install golang 1.13+ first"
+ @echo "ERROR: Need to install golang 1.16+ first"
exit 1
endif
-
+ @if [ "${GO_MAJOR}" -lt "${REQUIRED_MIN_GO_MAJOR}" ] ; then \
+ echo "ERROR: Need to install golang 1.16+ first"; \
+ exit 1; \
+ fi
+ @if [ "${GO_MINOR}" -lt "${REQUIRED_MIN_GO_MINOR}" ] ; then \
+ echo "ERROR: Need to install golang 1.16+ first"; \
+ exit 1; \
+ fi
Review comment:
Why I wrote such horrible logic🤣🤣
Changing ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
