spacewander commented on a change in pull request #4164:
URL: https://github.com/apache/apisix/pull/4164#discussion_r628984645
##########
File path: apisix/init.lua
##########
@@ -620,6 +619,15 @@ end
function _M.http_log_phase()
local api_ctx = common_phase("log")
+ if not api_ctx then
+ local ctx = ctxdump.apply_ngx_ctx(ngx_var.ctx_ref)
Review comment:
Why not reapply the ctx in `http_header_filter_phase`?
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -617,6 +642,17 @@ http {
proxy_pass $upstream_mirror_host$request_uri;
}
{% end %}
+
+ location = /50x.html {
Review comment:
Would it be better to use `named location`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
