spacewander commented on a change in pull request #4218:
URL: https://github.com/apache/apisix/pull/4218#discussion_r630643276
##########
File path: t/plugin/log-rotate.t
##########
@@ -173,11 +173,13 @@ plugins:
end
end
- ngx.say(n_split_error_file)
+ -- Before hot reload, the log rotate may or may not take effect.
Review comment:
We don't need to check if the rotation takes effect, it is checked by
another test.
We only need to check if the rotation can be disabled, so there is no need
to introduce extra sleep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
