[GitHub] [apisix] gxthrj commented on a change in pull request #4208: feat: support passing different host headers in multiple nodes

[GitBox]

gxthrj commented on a change in pull request #4208:
URL: https://github.com/apache/apisix/pull/4208#discussion_r631116345



##########
File path: t/node/upstream.t
##########
@@ -394,3 +394,119 @@ GET /t
 {"error_msg":"can not delete this upstream, route [1] is still using it now"}
 --- no_error_log
 [error]
+
+
+
+=== TEST 17: multi nodes with `node` mode to pass host
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local code, body = t('/apisix/admin/upstreams/1',
+                 ngx.HTTP_PUT,
+                 [[{
+                    "nodes": {
+                        "localhost:1979": 1000,
+                        "127.0.0.1:1980": 1

Review comment:
       I am not very familiar with test grammar.
   With weight 1000:1, the request should hit localhost:1979.
   In the Test 18 below, should host be `localhost`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org