bisakhmondal commented on a change in pull request #1788:
URL: https://github.com/apache/apisix-dashboard/pull/1788#discussion_r636605979
##########
File path: api/cmd/html/index.html
##########
@@ -0,0 +1,36 @@
+<!--
Review comment:
Yes, that's exactly what I have added.
`make build` full build with the web embed.
`make api-run` run without embed.
[new] `make api-build` build(just the manager-api) without embed.
Now as you see, we have 2 cases when we are not building web assets. maybe
as a substitute for this current `index.html`, we can create an empty directory
`html` and an empty file, maybe `keep.keep`. This would work fine. But I
thought, instead of an empty file an HTML with a suitable message (`The build
is partial`) would be appropriate.
So should we go with the other option just I mentioned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
