bzp2010 commented on a change in pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#discussion_r683128998
########## File path: Dockerfile ########## @@ -16,13 +16,12 @@ # FROM alpine:latest as pre-build -ARG APISIX_DASHBOARD_VERSION=master +ARG APISIX_DASHBOARD_GITHASH=00000000 + +ADD . /usr/local/apisix-dashboard RUN set -x \ - && apk add --no-cache --virtual .builddeps git \ - && git clone https://github.com/apache/apisix-dashboard.git -b ${APISIX_DASHBOARD_VERSION} /usr/local/apisix-dashboard \ - && cd /usr/local/apisix-dashboard && git clean -Xdf \ - && rm -f ./.githash && git log --pretty=format:"%h" -1 > ./.githash + && echo ${APISIX_DASHBOARD_GITHASH:0:8} > ./.githash Review comment: #### Changes - Modify dockerfile to compile with local branch code. - Instead of getting githash from clone's code, pass in githash variable through GitHub actions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
