bzp2010 commented on a change in pull request #2144:
URL: https://github.com/apache/apisix-dashboard/pull/2144#discussion_r714877009
##########
File path: api/internal/core/entity/entity.go
##########
@@ -58,14 +58,6 @@ func (info *BaseInfo) KeyCompat(key string) {
}
}
-type BaseInfoSetter interface {
- GetBaseInfo() *BaseInfo
-}
-
-type BaseInfoGetter interface {
- GetBaseInfo() *BaseInfo
-}
Review comment:
`BaseInfoGetter` and `BaseInfoSetter` are currently replaced by
`GetBaseInfo` interface (define in `interface.go`). Their interface definitions
are exactly the same. And, the lines of codes is reduced.
[https://github.com/apache/apisix-dashboard/blob/d908a70f0b81dbe65183346c16bbeb5ca2ceaeb6/api/internal/core/entity/interface.go#L17-L22](https://github.com/apache/apisix-dashboard/blob/d908a70f0b81dbe65183346c16bbeb5ca2ceaeb6/api/internal/core/entity/interface.go#L17-L22)
##########
File path: api/internal/core/entity/entity.go
##########
@@ -58,14 +58,6 @@ func (info *BaseInfo) KeyCompat(key string) {
}
}
-type BaseInfoSetter interface {
- GetBaseInfo() *BaseInfo
-}
-
-type BaseInfoGetter interface {
- GetBaseInfo() *BaseInfo
-}
Review comment:
ping @nic-chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
