tao12345666333 commented on a change in pull request #231: URL: https://github.com/apache/apisix-docker/pull/231#discussion_r724179821
########## File path: example/prometheus_conf/prometheus.yml ########## @@ -0,0 +1,23 @@ +global: + scrape_interval: 1s # By default, scrape targets every 15 seconds. + + # Attach these labels to any time series or alerts when communicating with + # external systems (federation, remote storage, Alertmanager). + external_labels: + monitor: "codelab-monitor" Review comment: In fact, this label can be considered to be used to mark the current prometheus instance. Here we can leave it unset, or set a more meaningful label for it. like this: ```suggestion stack: "apisix" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org