spacewander commented on a change in pull request #3894:
URL: https://github.com/apache/apisix/pull/3894#discussion_r725731119
##########
File path: apisix/plugins/ldap-auth.lua
##########
@@ -96,8 +96,8 @@ local function extract_auth_header(authorization)
local decoded, err = ngx.decode_base64(m[1])
- if err then
- return nil, "failed to decode authentication header"
+ if not decoded or err then
Review comment:
ngx.decode_base64 doesn't return err.
See https://github.com/openresty/lua-nginx-module#ngxdecode_base64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
