rapiz1 commented on pull request #5350:
URL: https://github.com/apache/apisix/pull/5350#issuecomment-953738185
I've thinked about it but failed to come up with a comprehensive method to
test. In fact, the function itself is not exhaustive about all possible aur
helpers. But you do remind me that the function could be more robust, like if
not finding an aur helper, emit an error and hints.
---Original---
From: "Alex ***@***.***>
Date: Thu, Oct 28, 2021 18:40 PM
To: ***@***.***>;
Cc: "Yujia ***@***.******@***.***>;
Subject: Re: [apache/apisix] feat: Support installation on arch (PR #5350)
@tokers commented on this pull request.
nit comment.
In utils/install-dependencies.sh:
> @@ -19,6 +19,26 @@ set -ex +function detect_aur_helper() { +if [[
$(which yay) ]]; then +AUR_HELPER=yay +elif [[ $(which pacaur) ]]; then
+AUR_HELPER=pacaur +fi +} + +function install_dependencies_with_aur() {
+detect_aur_helper
Shall we have some tests to cover it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
