Xunzhuo commented on a change in pull request #5354:
URL: https://github.com/apache/apisix/pull/5354#discussion_r740774269



##########
File path: t/plugin/limit-conn2.t
##########
@@ -308,3 +308,134 @@ request latency is nil
 --- error_code: 400
 --- response_body
 {"error_msg":"failed to check the configuration of plugin limit-conn err: 
property \"rejected_msg\" validation failed: string too short, expected at 
least 1, got 0"}
+
+
+
+=== TEST 9: set key type to var_combination
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local code, body = t('/apisix/admin/routes/1',
+                 ngx.HTTP_PUT,
+                 [[{
+                        "plugins": {
+                            "limit-conn": {
+                                "conn": 2,
+                                "burst": 1,
+                                "default_conn_delay": 0.1,
+                                "rejected_code": 503,
+                                "key": "$http_a $http_b",

Review comment:
       @tzssangglass  would you like to take a look at this PR again? doc 
updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to