tao12345666333 commented on a change in pull request #196:
URL: https://github.com/apache/apisix-helm-chart/pull/196#discussion_r769316230
##########
File path: charts/apisix/templates/service-admin.yaml
##########
@@ -25,6 +25,7 @@ metadata:
{{- end }}
labels:
{{- include "apisix.labels" . | nindent 4 }}
+ app.kubernetes.io/component: apisix-admin
Review comment:
In fact, from the semantics of `component`, they are the same componet.
I don’t think this label is reasonable enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
