tao12345666333 commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-1001109874
@neverCase Thanks for you contribution!!! The code in this PR is LGTM. In this PR, you not only implement the logic of the translator, but also increase the logic of the controller loop, so I hope you can add a little more content to ensure that its behavior meets our expectations. * modify the ApisixRoute CRD (only change the v2beta3 version) and add a reference to plugin Config https://github.com/apache/apisix-ingress-controller/blob/819b00318e8cd9b6639913301fb89d2acb168926/samples/deploy/crd/v1/ApisixRoute.yaml#L580-L822 * add e2e test case for ApisixRoute with PluginConfig. you can just add a simple case, e.g. enable `echo` and `cors` plugin at the same time. * https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/plugins/cors.go * https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/plugins/echo.go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
