nic-chen commented on a change in pull request #2271:
URL: https://github.com/apache/apisix-dashboard/pull/2271#discussion_r776936358
##########
File path: api/internal/core/store/validate.go
##########
@@ -165,12 +165,6 @@ func checkUpstream(upstream *entity.UpstreamDef) error {
return nil
}
- if upstream.PassHost == "node" && upstream.Nodes != nil {
- if nodes := entity.NodesFormat(upstream.Nodes);
len(nodes.([]*entity.Node)) != 1 {
- return fmt.Errorf("only support single node for `node`
mode currently")
- }
- }
Review comment:
should not remove this block of code. see:
https://github.com/apache/apisix/blob/master/apisix/upstream.lua#L397-L401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
