bisakhmondal commented on a change in pull request #6228:
URL: https://github.com/apache/apisix/pull/6228#discussion_r801290704



##########
File path: apisix/plugins/loggly.lua
##########
@@ -85,6 +86,17 @@ local schema = {
             type = "boolean",
             default = true
         },
+        severity_map = {
+            type = "object",
+            description = "upstream response code vs syslog severity mapping",
+            patternProperties = {
+                [".*"] = {

Review comment:
       Yea, I had tested. It doesn't work that way. 
   say for eg,
   `["^[1-5][0-9]{2}"] = {...}` the check schema match the enums for only the 
set of keys where the key is a status code (regex). For other scenarios (key = 
"ABC", "500a") there is no matching regex, so it simply doesn't match and 
validate with the pattern and let it pass as valid inputs.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to