zaunist commented on a change in pull request #6202:
URL: https://github.com/apache/apisix/pull/6202#discussion_r804510513
##########
File path: apisix/plugins/server-info.lua
##########
@@ -158,25 +159,65 @@ local function report(premature, report_ttl)
end
end
- server_info.last_report_time = ngx_time()
-
+ -- get inside etcd data, if not exist, create it
local key = "/data_plane/server_info/" .. server_info.id
- local ok, err = core.etcd.set(key, server_info, report_ttl)
+ local res, err = core.etcd.get(key)
+ if err ~= nil then
+ core.log.error("failed to get server_info from etcd: ", err)
+ end
+
+ if not res.body.node then
+ local res_new, err = core.etcd.set(key, server_info, report_ttl)
Review comment:
Can we set `modified_version ` to `nil`, I'm not sure if it can be set
to nil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
