kwanhur commented on a change in pull request #6306: URL: https://github.com/apache/apisix/pull/6306#discussion_r805466059
########## File path: utils/linux-install-luarocks.sh ########## @@ -42,7 +42,7 @@ fi make build > build.log 2>&1 || (cat build.log && exit 1) sudo make install > build.log 2>&1 || (cat build.log && exit 1) cd .. || exit -rm -rf luarocks-"$LUAROCKS_VER" +rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz Review comment: > Could we remove it just after untar? on this way, if `configure` failed, it need to download archive file `v3.8.0.tar.gz` repeatedly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org