tokers commented on a change in pull request #6281:
URL: https://github.com/apache/apisix/pull/6281#discussion_r806380660
##########
File path: apisix/core/string.lua
##########
@@ -78,4 +78,12 @@ function _M.rfind_char(s, ch, idx)
end
+-- reduce network consumption by compressing string indentation
Review comment:
I think the compress way is not ideal as it might also change the
literal string (spaces after `,`), so it should be used carefully, add some
comments to give a hint will be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
