zaunist commented on pull request #6202: URL: https://github.com/apache/apisix/pull/6202#issuecomment-1046241027
> > Hi, @tzssangglass . I checked `core.id.get()` and `core.utils.gethostname()`. It doesn't support updating ids and hostnames, it only gets them once when apisix starts, so it's not possible to update them in real time in the server-info plugin either. I'm sorry that this doesn't do what the proposal is trying to do. Maybe we can enhance `core.id.get` and `core.utils.hostname` to support regularly update id and hostname in a subsequent PR. > > My mistake, I should have pointed out that the test cases are written in shell script. Let's drop this test case for now and focus on finishing this PR. Yes, if we need to get the latest `id` and `hostname` etc., then we also need to update the `core.id.lua` and the code in `core.utils.lua` to support getting the latest status on a regular basis. My question is, do we have to do these changes in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
