champly commented on a change in pull request #872:
URL:
https://github.com/apache/apisix-ingress-controller/pull/872#discussion_r811504585
##########
File path: pkg/ingress/ingress.go
##########
@@ -192,18 +192,20 @@ func (c *ingressController) handleSyncErr(obj
interface{}, err error) {
event := ev.Object.(kube.IngressEvent)
namespace, name, errLocal := cache.SplitMetaNamespaceKey(event.Key)
if errLocal != nil {
- log.Errorf("invalid resource key: %s", event.Key)
+ log.Errorw("invalid resource key",
Review comment:
`cache.SplitMetaNamespaceKey` return `errLocal` include `key`
``` go
return "", "", fmt.Errorf("unexpected key format: %q", key)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
