spacewander commented on a change in pull request #6521:
URL: https://github.com/apache/apisix/pull/6521#discussion_r827636212



##########
File path: t/plugin/log-rotate2.t
##########
@@ -25,23 +25,6 @@ no_root_location();
 add_block_preprocessor(sub {
     my ($block) = @_;
 
-    my $user_yaml_config = <<_EOC_;
-apisix:
-  node_listen: 1984
-  admin_key: null
-
-plugins:                          # plugin list
-  - log-rotate
-
-plugin_attr:
-  log-rotate:
-    interval: 1
-    max_kept: 3
-    enable_compression: true
-_EOC_
-
-    $block->set_value("yaml_config", $user_yaml_config);

Review comment:
       We can check if yaml_config exists before setting it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to