tokers commented on a change in pull request #6745:
URL: https://github.com/apache/apisix/pull/6745#discussion_r837242850
##########
File path: apisix/plugins/authz-casbin.lua
##########
@@ -110,9 +110,9 @@ end
function _M.rewrite(conf, ctx)
-- creates an enforcer when request sent for the first time
- local ok, err = new_enforcer_if_need(conf)
+ local ok = new_enforcer_if_need(conf)
Review comment:
We need to log the error message or we as the admin cannot know the
details about the `503` requests.
##########
File path: apisix/plugins/authz-keycloak.lua
##########
@@ -572,7 +572,7 @@ local function evaluate_permissions(conf, ctx, token)
-- Ensure discovered data.
local err = authz_keycloak_ensure_discovered_data(conf)
if err then
- return 500, err
Review comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
