starsz commented on code in PR #6971: URL: https://github.com/apache/apisix/pull/6971#discussion_r861683042
########## conf/config-default.yaml: ########## @@ -315,6 +315,83 @@ etcd: # connect: 2000 # default 2000ms # send: 2000 # default 2000ms # read: 5000 # default 5000ms +# nacos: +# host: +# - "http://${username}:${password}@${host1}:${port1}"; +# prefix: "/nacos/v1/" +# fetch_interval: 30 # default 30 sec +# weight: 100 # default 100 +# timeout: +# connect: 2000 # default 2000 ms +# send: 2000 # default 2000 ms +# read: 5000 # default 5000 ms +# consul_kv: +# servers: +# - "http://127.0.0.1:8500"; +# - "http://127.0.0.1:8600"; +# prefix: "upstreams" +# skip_keys: # if you need to skip special keys +# - "upstreams/unused_api/" +# timeout: +# connect: 1000 # default 2000 ms +# read: 1000 # default 2000 ms +# wait: 60 # default 60 sec +# weight: 1 # default 1 +# fetch_interval: 5 # default 3 sec, only take effect for keepalive: false way +# keepalive: true # default true, use the long pull way to query consul servers +# default_server: # you can define default server when missing hit +# host: "127.0.0.1" +# port: 20999 +# metadata: +# fail_timeout: 1 # default 1 ms +# weight: 1 # default 1 +# max_fails: 1 # default 1 +# dump: # if you need, when registered nodes updated can dump into file +# path: "logs/consul_kv.dump" +# expire: 2592000 # unit sec, here is 30 day +# kubernetes: +# service: + # apiserver schema, options [http, https] +# schema: https #default https Review Comment: ```suggestion # schema: https # apiserver schema, options [http, https], default https ``` ########## conf/config-default.yaml: ########## @@ -315,6 +315,83 @@ etcd: # connect: 2000 # default 2000ms # send: 2000 # default 2000ms # read: 5000 # default 5000ms +# nacos: +# host: +# - "http://${username}:${password}@${host1}:${port1}"; +# prefix: "/nacos/v1/" +# fetch_interval: 30 # default 30 sec +# weight: 100 # default 100 +# timeout: +# connect: 2000 # default 2000 ms +# send: 2000 # default 2000 ms +# read: 5000 # default 5000 ms +# consul_kv: +# servers: +# - "http://127.0.0.1:8500"; +# - "http://127.0.0.1:8600"; +# prefix: "upstreams" +# skip_keys: # if you need to skip special keys +# - "upstreams/unused_api/" +# timeout: +# connect: 1000 # default 2000 ms +# read: 1000 # default 2000 ms +# wait: 60 # default 60 sec +# weight: 1 # default 1 +# fetch_interval: 5 # default 3 sec, only take effect for keepalive: false way +# keepalive: true # default true, use the long pull way to query consul servers +# default_server: # you can define default server when missing hit +# host: "127.0.0.1" +# port: 20999 +# metadata: +# fail_timeout: 1 # default 1 ms +# weight: 1 # default 1 +# max_fails: 1 # default 1 +# dump: # if you need, when registered nodes updated can dump into file +# path: "logs/consul_kv.dump" +# expire: 2592000 # unit sec, here is 30 day +# kubernetes: +# service: + # apiserver schema, options [http, https] +# schema: https #default https +# + # apiserver host, options [ipv4, ipv6, domain, environment variable] +# host: ${KUBERNETES_SERVICE_HOST} #default ${KUBERNETES_SERVICE_HOST} Review Comment: Ditto. ########## conf/config-default.yaml: ########## @@ -315,6 +315,83 @@ etcd: # connect: 2000 # default 2000ms # send: 2000 # default 2000ms # read: 5000 # default 5000ms +# nacos: +# host: +# - "http://${username}:${password}@${host1}:${port1}"; +# prefix: "/nacos/v1/" +# fetch_interval: 30 # default 30 sec +# weight: 100 # default 100 +# timeout: +# connect: 2000 # default 2000 ms +# send: 2000 # default 2000 ms +# read: 5000 # default 5000 ms +# consul_kv: +# servers: +# - "http://127.0.0.1:8500"; +# - "http://127.0.0.1:8600"; +# prefix: "upstreams" +# skip_keys: # if you need to skip special keys +# - "upstreams/unused_api/" +# timeout: +# connect: 1000 # default 2000 ms +# read: 1000 # default 2000 ms +# wait: 60 # default 60 sec +# weight: 1 # default 1 +# fetch_interval: 5 # default 3 sec, only take effect for keepalive: false way +# keepalive: true # default true, use the long pull way to query consul servers +# default_server: # you can define default server when missing hit +# host: "127.0.0.1" +# port: 20999 +# metadata: +# fail_timeout: 1 # default 1 ms +# weight: 1 # default 1 +# max_fails: 1 # default 1 +# dump: # if you need, when registered nodes updated can dump into file +# path: "logs/consul_kv.dump" +# expire: 2592000 # unit sec, here is 30 day +# kubernetes: +# service: + # apiserver schema, options [http, https] +# schema: https #default https +# + # apiserver host, options [ipv4, ipv6, domain, environment variable] +# host: ${KUBERNETES_SERVICE_HOST} #default ${KUBERNETES_SERVICE_HOST} +# + # apiserver port, options [port number, environment variable] +# port: ${KUBERNETES_SERVICE_PORT} #default ${KUBERNETES_SERVICE_PORT} +# +# client: + # serviceaccount token or token_file +# token_file: /var/run/secrets/kubernetes.io/serviceaccount/token Review Comment: ```suggestion # token_file: path/to/token # path of serviceaccount token_file ``` ########## conf/config-default.yaml: ########## @@ -315,6 +315,83 @@ etcd: # connect: 2000 # default 2000ms # send: 2000 # default 2000ms # read: 5000 # default 5000ms +# nacos: +# host: +# - "http://${username}:${password}@${host1}:${port1}"; +# prefix: "/nacos/v1/" +# fetch_interval: 30 # default 30 sec +# weight: 100 # default 100 +# timeout: +# connect: 2000 # default 2000 ms +# send: 2000 # default 2000 ms +# read: 5000 # default 5000 ms +# consul_kv: +# servers: +# - "http://127.0.0.1:8500"; +# - "http://127.0.0.1:8600"; +# prefix: "upstreams" +# skip_keys: # if you need to skip special keys +# - "upstreams/unused_api/" +# timeout: +# connect: 1000 # default 2000 ms +# read: 1000 # default 2000 ms +# wait: 60 # default 60 sec +# weight: 1 # default 1 +# fetch_interval: 5 # default 3 sec, only take effect for keepalive: false way +# keepalive: true # default true, use the long pull way to query consul servers +# default_server: # you can define default server when missing hit +# host: "127.0.0.1" +# port: 20999 +# metadata: +# fail_timeout: 1 # default 1 ms +# weight: 1 # default 1 +# max_fails: 1 # default 1 +# dump: # if you need, when registered nodes updated can dump into file +# path: "logs/consul_kv.dump" +# expire: 2592000 # unit sec, here is 30 day +# kubernetes: +# service: + # apiserver schema, options [http, https] +# schema: https #default https +# Review Comment: Redundant line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
