crazyMonkey1995 commented on code in PR #6988:
URL: https://github.com/apache/apisix/pull/6988#discussion_r870879873
##########
apisix/plugins/real-ip.lua:
##########
@@ -84,6 +103,17 @@ local function get_addr(conf, ctx)
return addrs
end
+ if conf.recursive and conf.trusted_addresses then
+ local split_addrs, _ = ngx_re_split(addrs, ",\\s*", "jo")
Review Comment:
Thanks for the review, the above if condition has already dealt with the
absence of commas, so there should be no need to deal with err here? I'm not
very familiar with lua, but this `_` may indeed be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
