kwanhur commented on code in PR #7049:
URL: https://github.com/apache/apisix/pull/7049#discussion_r877044976
##########
t/cli/test_admin.sh:
##########
@@ -112,6 +112,48 @@ if [ $count -eq 0 ]; then
exit 1
fi
+echo "
Review Comment:
Case as below I think it's ok.
The detail here, `yaml_conf.apisix.enable_admin` to `true`,
`yaml_conf.apisix.allow_admin` not empty, so it through into foreach element to
check `loopback` or not, but value `all` still stays `checked_admin_key` to
`false`.
So this case satisfies `if yaml_conf.apisix.enable_admin and not
checked_admin_key then` and walks inside.
Am I missing other? Please point it out, thanks very much.
```shell
echo "
apisix:
enable_admin: true
allow_admin:
- all
" > conf/config.yaml
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
