bisakhmondal commented on code in PR #7099: URL: https://github.com/apache/apisix/pull/7099#discussion_r901123107
########## apisix/plugins/elasticsearch-logger.lua: ########## @@ -0,0 +1,181 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to You under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. +-- + +local bp_manager_mod = require("apisix.utils.batch-processor-manager") +local log_util = require("apisix.utils.log-util") +local core = require("apisix.core") +local http = require("resty.http") +local url = require("net.url") +local plugin = require("apisix.plugin") + +local ngx = ngx +local tostring = tostring +local encode_base64 = ngx.encode_base64 + +local plugin_name = "elasticsearch-logger" +local batch_processor_manager = bp_manager_mod.new(plugin_name) + +local schema = { + type = "object", + properties = { + endpoint_addr = core.schema.uri_def, + user = {type = "string", default = ""}, + password = {type = "string", default = ""}, + index = {type = "string", default = ""}, + timeout = {type = "integer", minimum = 1, default = 3}, + name = {type = "string", default = "elasticsearch logger"}, + ssl_verify = {type = "boolean", default = true}, + }, + required = {"endpoint_addr", "user", "password", "index"} +} + + +local metadata_schema = { + type = "object", + properties = { + log_format = log_util.metadata_schema_log_format, + }, +} + + +local _M = { + version = 0.1, + priority = 398, + name = plugin_name, + schema = batch_processor_manager:wrap_schema(schema), + metadata_schema = metadata_schema, +} + + +function _M.check_schema(conf, schema_type) + if schema_type == core.schema.TYPE_METADATA then + return core.schema.check(metadata_schema, conf) + end + return core.schema.check(schema, conf) +end + + +local function send_http_data(conf, log_message) + local err_msg + local res = true + local url_decoded = url.parse(conf.endpoint_addr) + local host = url_decoded.host + local port = url_decoded.port + local index = conf.index .. "-" .. os.date('%Y.%m.%d') Review Comment: Hey, I think it's an antipattern - i.e. creating indices [each day] for storing logs. Cons: 1. Creating a new index might require elevated privileges [We can't force users to give us some hefty permission of their ES cluster]. 2. Issue with data query and aggregation. It's better to add a timestamp at the log message level. Easy to query, aggregate logs and requires no extra privileges -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
