Till Westmann has posted comments on this change. Change subject: WIP - QueryService API updates ......................................................................
Patch Set 6: (3 comments) Responding to Ian's questions. https://asterix-gerrit.ics.uci.edu/#/c/896/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java: Line 82: try { > How's this part work? Was this originally just doing what valueOf would've Yes, it was translating string to enums ... https://asterix-gerrit.ics.uci.edu/#/c/896/6/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java File asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java: Line 32: * As the response is not necessarily valid JSON, non-JSON content has to be extracted in some cases. > When is the response not JSON? When it's ADM/CSV? Yes, ADM and CSV are not JSON and are currently wrapped (even though that doesn't work correctly yet for CSV). I tried to simply ignore the structure and extract the ADM from the response field, but that got too messy. Line 109: > Whats the purpose of the 'type' field here? It provides the MIME-type of the content of the results field in the response. The MIME-type of the whole response always needs to be "application/json" as the wrapper is JSON. -- To view, visit https://asterix-gerrit.ics.uci.edu/896 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <michael.b...@couchbase.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
