Chris Hillery has posted comments on this change. Change subject: ASTERIXDB-1482: Added NCServiceExecutionIT, HyracksVirtualCluster. ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/958/3/asterixdb/asterix-server/pom.xml File asterixdb/asterix-server/pom.xml: Line 127: <plugin> > What's this plugin about? I copied these plugin settings from hyracks-server, where it's doing the same thing: making sure that the appassembler-generated .sh scripts are executable. https://asterix-gerrit.ics.uci.edu/#/c/958/3/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java: Line 135: LOGGER.info("Sleeping while cluster comes online..."); > Is there a better way to do this? Maybe trying to fetch against some port o I'm not sure.. I suppose it could poll the rest/nodes Hyracks endpoint until the expected number of NCs are connected? https://asterix-gerrit.ics.uci.edu/#/c/958/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java: Line 155 > Why remove this? Because it no longer serves any purpose, with VirtualClusterDriver removed. It was always an ugly hack that risked being out of sync, and with the NCService model I'm trying to minimize the use of command-line arguments anyway. -- To view, visit https://asterix-gerrit.ics.uci.edu/958 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3eb450782a595cf85d04a2c2e9cc732564e65e6 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery <c...@lambda.nu> Gerrit-Reviewer: Chris Hillery <c...@lambda.nu> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
