Preston Carman has posted comments on this change. Change subject: Sonar fixes and other clean up items. ......................................................................
Patch Set 4: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/999/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java: Line 76: throws AsterixException { > As these are runtime exceptions, could we make them HyracksDataExceptions? Done https://asterix-gerrit.ics.uci.edu/#/c/999/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java: Line 38: public boolean validateInterval(AIntervalPointable ip1) throws AsterixException { > HyracksDataException? Done. A little bit of a rabbit hole. https://asterix-gerrit.ics.uci.edu/#/c/999/4/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/TuplePointer.java: Line 21: public class TuplePointer implements IResetable<TuplePointer> { > Make TuplePointer final, so we can inline the getters? The tuple pointer has a reset method to change the pointer. Line 48: public boolean equals(Object o) { > How about this: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/999 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
