Preston Carman has posted comments on this change. Change subject: Sonar fixes and other clean up items. ......................................................................
Patch Set 6: (1 comment) Those changes can be saved for an other round of clean up. https://asterix-gerrit.ics.uci.edu/#/c/999/6/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java: Line 62: private final Map<Integer, List<Pair<IPushRuntimeFactory, RecordDescriptor>>> metaAsterixOpSkeletons = new HashMap<>(); > Would be nice to fix this. The eclipse formatting does not change this line to fit with in the 120 characters. -- To view, visit https://asterix-gerrit.ics.uci.edu/999 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes