Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1536: supports fully qualified dataset path in SQL++. ......................................................................
Patch Set 3: (1 comment) Till, I have added a negative test for ambiguous alias reference and addressed your comments. Best, Yingyi https://asterix-gerrit.ics.uci.edu/#/c/1008/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java: Line 116: + (dataverseName == null ? metadataProvider.getDefaultDataverseName() : dataverseName) > Maybe we can pull this out into a variable, so we don't do it once for the Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1008 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93c7187b3a363a82dbfa225eb67ab526e04aa2dd Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
