Chris Hillery has posted comments on this change.

Change subject: Ensure RMI host is set to the cluster ip address
......................................................................


Patch Set 2:

Mike - the client and cluster IPs for the CC are only the "public" IPs already. 
The client IP is obviously the one that external clients can see. As for 
cluster IP, the CC listens on all interfaces; the specific cluster IP is the 
one which is passed to NCs for connecting.

FYI, though, I'm no longer sure the whole public/private divide is really 
desirable. It was there primarily to support earlier limitations in Docker, but 
that's long ago. It'd still be useful if you were setting up a cluster where 
some nodes were behind NAT or something, but I can't imagine that's really a 
common use case. It might be worth stripping it out to avoid confusions.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1065
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fbda4ce14c892e66595d7a1cc3801f0fc2b8fba
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Chris Hillery <c...@lambda.nu>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Reply via email to