Till Westmann has posted comments on this change. Change subject: Add Asterix Extension Manager ......................................................................
Patch Set 14: (8 comments) Just a few minor comments from me. But Yingyi's points are important. I'll try to provide a patch for an alternate approach for the Statement.getAPI() issue. https://asterix-gerrit.ics.uci.edu/#/c/1017/14/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/ExtensionFunctionIdentifier.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/ExtensionFunctionIdentifier.java: Line 60: } > Override hashCode()? Good point! https://asterix-gerrit.ics.uci.edu/#/c/1017/14/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java: Line 112: } ; remove space and semicolon Line 233: } Would be nice to pull out ((AqlDataSource) dataSourceScan.getDataSource()).getDatasourceType() BTW, do we know that the cast to (AqlDataSource) will always succeed? https://asterix-gerrit.ics.uci.edu/#/c/1017/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java: Line 66: this.compilationProvider = compilationProvider; WS https://asterix-gerrit.ics.uci.edu/#/c/1017/14/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsxExtension.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsxExtension.java: Line 25: public class AsxExtension { What does AsxExtension stand for? https://asterix-gerrit.ics.uci.edu/#/c/1017/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataIndex.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataIndex.java: Line 89: assert typesNamesMatch; Don't "assert", throw an AssertionError. "asserts" can be switched off by the JVM, the throwing of the error doesn't go away. https://asterix-gerrit.ics.uci.edu/#/c/1017/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlDataSource.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlDataSource.java: Line 232: throws AlgebricksException; Could you file an issue that we need to revisit this API? https://asterix-gerrit.ics.uci.edu/#/c/1017/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java: Line 47: int nodeParitions = s/nodeParitions/nodePartitions/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1017 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I280268495cc3aad00f898cba21f7299f7120ce5c Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
