Yingyi Bu has posted comments on this change. Change subject: Add Asterix Extension Manager ......................................................................
Patch Set 15: (3 comments) 1. Can you make a pass over the Sonar Qube comments? I guess most of them can be addressed except few exceptions: - complexity of the method.... - lines in a case branch... - not to use System.out 2. As we discussed yesterday, could you make the handling of OperatorDescriptor and ConnectorDescriptor for setOperatorId() and setConnectorId() in a consistent way? In other words, remove the clone() methods in connectors? https://asterix-gerrit.ics.uci.edu/#/c/1017/15/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ConstantExpressionUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ConstantExpressionUtils.java: Line 36: private ConstantExpressionUtils() { Remove that class, merge the latest master, and use the one Till added? https://asterix-gerrit.ics.uci.edu/#/c/1017/15/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ExtensionId.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ExtensionId.java: Line 38: return getName().hashCode(); Use ObjectUtils.hashMulti(...) to add version as well? https://asterix-gerrit.ics.uci.edu/#/c/1017/15/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFile.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFile.java: Line 123: return fileName.hashCode(); Use ObjectUtils.hashMulti(...) to include dataverseName and datasetName. -- To view, visit https://asterix-gerrit.ics.uci.edu/1017 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I280268495cc3aad00f898cba21f7299f7120ce5c Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
