Steven Jacobs has posted comments on this change. Change subject: ASTERIXDB-1587 Test upsert when using foreign datatype ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1091/1/asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/drop-dataverse/drop-dataverse.1.ddl.aql: Line 30: create dataverse a; I'm going to pre-reply to the question here. Since we enabled datasets to use foreign datatypes, drop dataverse will return an error when the dataverse has sets using foreign datatypes. Because of this, my foreign datatype tests use two dataverse, a and b. Since b creates datasets that depends on datatypes from a, b must be dropped before a (since our tests aren't actually jUnit tests). This test had it backwards, which made the test fail. -- To view, visit https://asterix-gerrit.ics.uci.edu/1091 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c374a44389af5916c8398afb3be8628b7872389 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
