Taewoo Kim has posted comments on this change. Change subject: Fulltext search initial implementation ......................................................................
Patch Set 14: 1) Is it really necessary to change every line of asterixdb/asterix-app/data/csv/fragile_02.adm? One of field-name needs to be changed to remove any confusions (name:text field since it is overlapped with a new reserved keyword - text). 2) It seems that there are a number of quite reasonable SonarQube comments (not all are ...). Why didn't you address them? I have gone through once. Let me check again to make sure. 3) Why is FULLTEXT_CONTAINS added to AlgebricksBuiltinFunctions? It seems that it's never used in Algebricks.. Since a fulltext_search is one of comparison-kind function and I thought it's reasonable to put it there (=the same level as other comparison operations <, >, = ...). -- To view, visit https://asterix-gerrit.ics.uci.edu/989 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Heri Ramampiaro <heri...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: No
