abdullah alamoudi has posted comments on this change. Change subject: Refactor AqlMetadataProvider ......................................................................
Patch Set 1: (2 comments) rebase and address the small comments? also maybe with rebase, refactor the aqlDataSource getdatascan runtime? https://asterix-gerrit.ics.uci.edu/#/c/1016/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataManagerHelper.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataManagerHelper.java: Line 48: private final AqlMetadataProvider aqlMetadataProvider; I think we should make this class completely static and we should never pass aqlMetadataProvider even as a parameter Line 49: private MetadataTransactionContext mdTxnCtx; mdTxnCtx is inside of aqlMetadataProvider so there is no need for it to be a member here! -- To view, visit https://asterix-gerrit.ics.uci.edu/1016 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2720817c5659622e1f713653856825d612eb892 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
