Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1186: fixed a composite primary index search issue. ......................................................................
Patch Set 5: (2 comments) Obtain the index info (composite or not, number of fields from AqlIndex) in BTreeSearchOperator, such that other source files can stay unchanged. https://asterix-gerrit.ics.uci.edu/#/c/1094/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java: Line 84: this.isCompositeIndex = isCompositeIndex; The detour from btreeJobGenParams to obtain isCompositeIndex and numberOfKeyFields seems awkward to me. Can we directly obtain the information from idx (AqlIndex) in the if-block at line 154? E.g., add a private method in this class to obtain the info from idx. Line 156: || (isCompositeIndex && (lowKeyVarList.size() == numberOfKeyFields) remove isCompositeIndex in the right branch of "||" -- To view, visit https://asterix-gerrit.ics.uci.edu/1094 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
