Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1611: reasonable names for threads ......................................................................
Patch Set 5: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1092/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java: Line 206: LOGGER.severe("Global recovery was not completed successfully: " + e); > Can we not lose the exception, i.e. LOGGER.severe(msg + e); -> LOGGER.log(L Done Line 211: LOGGER.severe("Exception in aborting" + e.getMessage()); > same as above Done Line 222: while (recoveryThread.isAlive()) { > I assume it's OK to block until recovery has completed? Should we rename t I'm actually not sure if it's ok/desirable. Need to understand the lifecycle better ... https://asterix-gerrit.ics.uci.edu/#/c/1092/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java: Line 251: Iterator<String> iter = nodeNames.iterator(); > for (String nodeName : nodeNames) ...? Done https://asterix-gerrit.ics.uci.edu/#/c/1092/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java: Line 105: setName("Worker" + super.getName()); > will these names potentially be confusing since the numbers will be indepen As there's only one thread per queue, I've added an identifier for the queue and derive the thread name from the identifier. -- To view, visit https://asterix-gerrit.ics.uci.edu/1092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fea28c9e0ea7c3baad1c7a053adabc71bea2a8a Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
