abdullah alamoudi has posted comments on this change. Change subject: Refactor Active Listeners ......................................................................
Patch Set 3: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1118/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java: Line 87: if (dataSource instanceof IMutationDataSource) { > It seems that we got something wrong here - we should be able to get enough Done https://asterix-gerrit.ics.uci.edu/#/c/1118/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 1416: if (listener.isEntityConnectedToDataset(dataverseName, datasetName)) { > For indexes it seems that we can ask the metadata manager which indexes are I don't understand the connection. This has nothing to do with indexes but with datasets. If we want to do some ddl change to a dataset (drop/create-index,drop-index), we need to ensure that it is not connected to an active job (feed, or ,other active jobs). what am I missing? Line 3113: if (mdTxnCtx != null) { > How do we get to the place where the ctx is null? Sounds scary ... Right now, we don't and I can revert this :) https://asterix-gerrit.ics.uci.edu/#/c/1118/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedEventsListener.java: Line 646: public boolean isEntityConnectedToDataset(String dataverseName, String datasetName) { > Hmm, why is it ok to ignore the dataverse? It is not, this is just the result of refactoring. currently, we don't do the check because we only allow a feed to feed into datasets under the same dataverse, hence, we know it will be equal. https://asterix-gerrit.ics.uci.edu/#/c/1118/3/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IDataSource.java: Line 35: public boolean isLeaf(); > Hmm, shouldn't the "leaf" property be the property of an operator in the tr Done https://asterix-gerrit.ics.uci.edu/#/c/1118/3/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 271: if (dataSource.isLeaf()) { > The "leaf" property doesn't seem right here either. I am just making it part of the datasource implementation since the implementation implies that. I just renamed it to make better sense. -- To view, visit https://asterix-gerrit.ics.uci.edu/1118 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I260c8608329523f56dc54780d87d796f838505cf Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
