Till Westmann has posted comments on this change. Change subject: Add result location HTTP API. ......................................................................
Patch Set 1: (4 comments) I've got a few comments in the source and a few requests :) 1) Could you add a test? 2) Could you file an issue about the weak error handling capabilities of the result distribution framework that mentions that a) HyracksDatasetReader.getResultStatus ignores exceptions and b) DatasetDirectoryService.getResultStatus hangs forever on an invalid jobId? https://asterix-gerrit.ics.uci.edu/#/c/1178/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java: Line 14: */ Please use an Apache license header. Line 56: String strHandle = request.getParameter("handle"); Handle the case if no handle is given. Should probably return a 400. Line 81: JSONArray handle = handleObj.getJSONArray("handle"); Check the syntax of the handle. Line 116: out.println(e.getMessage()); Could we produce a JSON error like { "errors": [ { "msg" : "bla bla" } ] } here? -- To view, visit https://asterix-gerrit.ics.uci.edu/1178 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet <wael....@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
