Steven Jacobs has posted comments on this change. Change subject: Interval join test questions for AQL. ......................................................................
Patch Set 2: (1 comment) One comment https://asterix-gerrit.ics.uci.edu/#/c/1234/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/IntervalLogic.java: Line 120: && ch.compare(ip1.getTypeTag(), ip2.getTypeTag(), e1, s2) != 0 Why can't >=0 AND != 0 just be >0 -- To view, visit https://asterix-gerrit.ics.uci.edu/1234 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e492d1afba693a50cb75918399c26b8ce19899a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
