Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1671: fix non-positive limit with order by. ......................................................................
Patch Set 2: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1240/2/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-1671.sqlpp File asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-1671.sqlpp: Line 19: Let's put a description here - what this test tries to test. https://asterix-gerrit.ics.uci.edu/#/c/1240/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671-2/query-ASTERIXDB-1671-2.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671-2/query-ASTERIXDB-1671-2.1.ddl.sqlpp: Line 19: Let's put a description here - what this test tries to test. https://asterix-gerrit.ics.uci.edu/#/c/1240/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671/query-ASTERIXDB-1671.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671/query-ASTERIXDB-1671.1.ddl.sqlpp: Line 19: Let's put a description here - what this test tries to test. https://asterix-gerrit.ics.uci.edu/#/c/1240/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/StableSortPOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/StableSortPOperator.java: Line 101: // topK == -1 means that a topK value is not provided. We need to care about this part, too. I used -1 as no topK. So, I think if a negative number is provided by a user, then it should be set to -1. Line 121: if (orderProp == null) { This part, too. -- To view, visit https://asterix-gerrit.ics.uci.edu/1240 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id28218c100e4cca0f94e37eda82d3bc6ae78322f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
